Google Git
Sign in
code/git/68ffe095a25b4aba1d6aa1386318ddc8dadcf8c2
commit
68ffe095a25b4aba1d6aa1386318ddc8dadcf8c2
[log]
author
Andrzej Hunt <ajrhunt@google.com>
Sun Mar 21 16:58:37 2021 +0000
committer
Junio C Hamano <gitster@pobox.com>
Sun Mar 21 14:39:10 2021 -0700
tree
ac1ed83ff3c9df7fdfa5981134e551709b67381f
parent
64cc539fd2f8e02f39cfae21e9523da2532c0467 [diff]
transport: also free remote_refs in transport_disconnect()

transport_get_remote_refs() can populate the transport struct's
remote_refs. transport_disconnect() is already responsible for most of
transport's cleanup - therefore we also take care of freeing remote_refs
there.

There are 2 locations where transport_disconnect() is called before
we're done using the returned remote_refs. This patch changes those
callsites to only call transport_disconnect() after the returned refs
are no longer being used - which is necessary to safely be able to
free remote_refs during transport_disconnect().

This commit fixes the following leak which was found while running
t0000, but is expected to also fix the same pattern of leak in all
locations that use transport_get_remote_refs():

Direct leak of 165 byte(s) in 1 object(s) allocated from:
    #0 0x49a6b2 in calloc /home/abuild/rpmbuild/BUILD/llvm-11.0.0.src/build/../projects/compiler-rt/lib/asan/asan_malloc_linux.cpp:154:3
    #1 0x9a72f2 in xcalloc /home/ahunt/oss-fuzz/git/wrapper.c:140:8
    #2 0x8ce203 in alloc_ref_with_prefix /home/ahunt/oss-fuzz/git/remote.c:867:20
    #3 0x8ce1a2 in alloc_ref /home/ahunt/oss-fuzz/git/remote.c:875:9
    #4 0x72f63e in process_ref_v2 /home/ahunt/oss-fuzz/git/connect.c:426:8
    #5 0x72f21a in get_remote_refs /home/ahunt/oss-fuzz/git/connect.c:525:8
    #6 0x979ab7 in handshake /home/ahunt/oss-fuzz/git/transport.c:305:4
    #7 0x97872d in get_refs_via_connect /home/ahunt/oss-fuzz/git/transport.c:339:9
    #8 0x9774b5 in transport_get_remote_refs /home/ahunt/oss-fuzz/git/transport.c:1388:4
    #9 0x51cf80 in cmd_clone /home/ahunt/oss-fuzz/git/builtin/clone.c:1271:9
    #10 0x4cd60d in run_builtin /home/ahunt/oss-fuzz/git/git.c:453:11
    #11 0x4cb2da in handle_builtin /home/ahunt/oss-fuzz/git/git.c:704:3
    #12 0x4ccc37 in run_argv /home/ahunt/oss-fuzz/git/git.c:771:4
    #13 0x4cac29 in cmd_main /home/ahunt/oss-fuzz/git/git.c:902:19
    #14 0x69c45e in main /home/ahunt/oss-fuzz/git/common-main.c:52:11
    #15 0x7f6a459d5349 in __libc_start_main (/lib64/libc.so.6+0x24349)

Signed-off-by: Andrzej Hunt <ajrhunt@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
3 files changed
tree: ac1ed83ff3c9df7fdfa5981134e551709b67381f
  1. .github/
  2. block-sha1/
  3. builtin/
  4. ci/
  5. compat/
  6. contrib/
  7. Documentation/
  8. ewah/
  9. git-gui/
  10. gitk-git/
  11. gitweb/
  12. mergetools/
  13. negotiator/
  14. perl/
  15. po/
  16. ppc/
  17. refs/
  18. sha1dc/
  19. sha256/
  20. t/
  21. templates/
  22. trace2/
  23. vcs-svn/
  24. xdiff/
  25. sha1collisiondetection
  26. RelNotes ⇨ Documentation/RelNotes/2.31.0.txt
  27. .cirrus.yml
  28. .clang-format
  29. .editorconfig
  30. .gitattributes
  31. .gitignore
  32. .gitmodules
  33. .mailmap
  34. .travis.yml
  35. .tsan-suppressions
  36. abspath.c
  37. aclocal.m4
  38. add-interactive.c
  39. add-interactive.h
  40. add-patch.c
  41. advice.c
  42. advice.h
  43. alias.c
  44. alias.h
  45. alloc.c
  46. alloc.h
  47. apply.c
  48. apply.h
  49. archive-tar.c
  50. archive-zip.c
  51. archive.c
  52. archive.h
  53. attr.c
  54. attr.h
  55. banned.h
  56. base85.c
  57. bisect.c
  58. bisect.h
  59. blame.c
  60. blame.h
  61. blob.c
  62. blob.h
  63. bloom.c
  64. bloom.h
  65. branch.c
  66. branch.h
  67. builtin.h
  68. bulk-checkin.c
  69. bulk-checkin.h
  70. bundle.c
  71. bundle.h
  72. cache-tree.c
  73. cache-tree.h
  74. cache.h
  75. chdir-notify.c
  76. chdir-notify.h
  77. check-builtins.sh
  78. check_bindir
  79. checkout.c
  80. checkout.h
  81. chunk-format.c
  82. chunk-format.h
  83. CODE_OF_CONDUCT.md
  84. color.c
  85. color.h
  86. column.c
  87. column.h
  88. combine-diff.c
  89. command-list.txt
  90. commit-graph.c
  91. commit-graph.h
  92. commit-reach.c
  93. commit-reach.h
  94. commit-slab-decl.h
  95. commit-slab-impl.h
  96. commit-slab.h
  97. commit.c
  98. commit.h
  99. common-main.c
  100. config.c
  101. config.h
  102. config.mak.dev
  103. config.mak.in
  104. config.mak.uname
  105. configure.ac
  106. connect.c
  107. connect.h
  108. connected.c
  109. connected.h
  110. convert.c
  111. convert.h
  112. copy.c
  113. COPYING
  114. credential.c
  115. credential.h
  116. csum-file.c
  117. csum-file.h
  118. ctype.c
  119. daemon.c
  120. date.c
  121. decorate.c
  122. decorate.h
  123. delta-islands.c
  124. delta-islands.h
  125. delta.h
  126. detect-compiler
  127. diff-delta.c
  128. diff-lib.c
  129. diff-merges.c
  130. diff-merges.h
  131. diff-no-index.c
  132. diff.c
  133. diff.h
  134. diffcore-break.c
  135. diffcore-delta.c
  136. diffcore-order.c
  137. diffcore-pickaxe.c
  138. diffcore-rename.c
  139. diffcore-rotate.c
  140. diffcore.h
  141. dir-iterator.c
  142. dir-iterator.h
  143. dir.c
  144. dir.h
  145. editor.c
  146. entry.c
  147. environment.c
  148. environment.h
  149. exec-cmd.c
  150. exec-cmd.h
  151. fetch-negotiator.c
  152. fetch-negotiator.h
  153. fetch-pack.c
  154. fetch-pack.h
  155. fmt-merge-msg.c
  156. fmt-merge-msg.h
  157. fsck.c
  158. fsck.h
  159. fsmonitor.c
  160. fsmonitor.h
  161. fuzz-commit-graph.c
  162. fuzz-pack-headers.c
  163. fuzz-pack-idx.c
  164. generate-cmdlist.sh
  165. generate-configlist.sh
  166. gettext.c
  167. gettext.h
  168. git-add--interactive.perl
  169. git-archimport.perl
  170. git-bisect.sh
  171. git-compat-util.h
  172. git-cvsexportcommit.perl
  173. git-cvsimport.perl
  174. git-cvsserver.perl
  175. git-difftool--helper.sh
  176. git-filter-branch.sh
  177. git-instaweb.sh
  178. git-merge-octopus.sh
  179. git-merge-one-file.sh
  180. git-merge-resolve.sh
  181. git-mergetool--lib.sh
  182. git-mergetool.sh
  183. git-p4.py
  184. git-quiltimport.sh
  185. git-rebase--preserve-merges.sh
  186. git-request-pull.sh
  187. git-send-email.perl
  188. git-sh-i18n.sh
  189. git-sh-setup.sh
  190. git-submodule.sh
  191. git-svn.perl
  192. GIT-VERSION-GEN
  193. git-web--browse.sh
  194. git.c
  195. git.rc
  196. gpg-interface.c
  197. gpg-interface.h
  198. graph.c
  199. graph.h
  200. grep.c
  201. grep.h
  202. hash-lookup.c
  203. hash-lookup.h
  204. hash.h
  205. hashmap.c
  206. hashmap.h
  207. help.c
  208. help.h
  209. hex.c
  210. http-backend.c
  211. http-fetch.c
  212. http-push.c
  213. http-walker.c
  214. http.c
  215. http.h
  216. ident.c
  217. imap-send.c
  218. INSTALL
  219. iterator.h
  220. json-writer.c
  221. json-writer.h
  222. khash.h
  223. kwset.c
  224. kwset.h
  225. levenshtein.c
  226. levenshtein.h
  227. LGPL-2.1
  228. line-log.c
  229. line-log.h
  230. line-range.c
  231. line-range.h
  232. linear-assignment.c
  233. linear-assignment.h
  234. list-objects-filter-options.c
  235. list-objects-filter-options.h
  236. list-objects-filter.c
  237. list-objects-filter.h
  238. list-objects.c
  239. list-objects.h
  240. list.h
  241. ll-merge.c
  242. ll-merge.h
  243. lockfile.c
  244. lockfile.h
  245. log-tree.c
  246. log-tree.h
  247. ls-refs.c
  248. ls-refs.h
  249. mailinfo.c
  250. mailinfo.h
  251. mailmap.c
  252. mailmap.h
  253. Makefile
  254. match-trees.c
  255. mem-pool.c
  256. mem-pool.h
  257. merge-blobs.c
  258. merge-blobs.h
  259. merge-ort-wrappers.c
  260. merge-ort-wrappers.h
  261. merge-ort.c
  262. merge-ort.h
  263. merge-recursive.c
  264. merge-recursive.h
  265. merge.c
  266. mergesort.c
  267. mergesort.h
  268. midx.c
  269. midx.h
  270. name-hash.c
  271. notes-cache.c
  272. notes-cache.h
  273. notes-merge.c
  274. notes-merge.h
  275. notes-utils.c
  276. notes-utils.h
  277. notes.c
  278. notes.h
  279. object-file.c
  280. object-name.c
  281. object-store.h
  282. object.c
  283. object.h
  284. oid-array.c
  285. oid-array.h
  286. oidmap.c
  287. oidmap.h
  288. oidset.c
  289. oidset.h
  290. pack-bitmap-write.c
  291. pack-bitmap.c
  292. pack-bitmap.h
  293. pack-check.c
  294. pack-objects.c
  295. pack-objects.h
  296. pack-revindex.c
  297. pack-revindex.h
  298. pack-write.c
  299. pack.h
  300. packfile.c
  301. packfile.h
  302. pager.c
  303. parse-options-cb.c
  304. parse-options.c
  305. parse-options.h
  306. patch-delta.c
  307. patch-ids.c
  308. patch-ids.h
  309. path.c
  310. path.h
  311. pathspec.c
  312. pathspec.h
  313. pkt-line.c
  314. pkt-line.h
  315. preload-index.c
  316. pretty.c
  317. pretty.h
  318. prio-queue.c
  319. prio-queue.h
  320. progress.c
  321. progress.h
  322. promisor-remote.c
  323. promisor-remote.h
  324. prompt.c
  325. prompt.h
  326. protocol.c
  327. protocol.h
  328. prune-packed.c
  329. prune-packed.h
  330. quote.c
  331. quote.h
  332. range-diff.c
  333. range-diff.h
  334. reachable.c
  335. reachable.h
  336. read-cache.c
  337. README.md
  338. rebase-interactive.c
  339. rebase-interactive.h
  340. rebase.c
  341. rebase.h
  342. ref-filter.c
  343. ref-filter.h
  344. reflog-walk.c
  345. reflog-walk.h
  346. refs.c
  347. refs.h
  348. refspec.c
  349. refspec.h
  350. remote-curl.c
  351. remote.c
  352. remote.h
  353. replace-object.c
  354. replace-object.h
  355. repo-settings.c
  356. repository.c
  357. repository.h
  358. rerere.c
  359. rerere.h
  360. reset.c
  361. reset.h
  362. resolve-undo.c
  363. resolve-undo.h
  364. revision.c
  365. revision.h
  366. run-command.c
  367. run-command.h
  368. send-pack.c
  369. send-pack.h
  370. sequencer.c
  371. sequencer.h
  372. serve.c
  373. serve.h
  374. server-info.c
  375. setup.c
  376. sh-i18n--envsubst.c
  377. sha1dc_git.c
  378. sha1dc_git.h
  379. shallow.c
  380. shallow.h
  381. shell.c
  382. shortlog.h
  383. sideband.c
  384. sideband.h
  385. sigchain.c
  386. sigchain.h
  387. split-index.c
  388. split-index.h
  389. stable-qsort.c
  390. strbuf.c
  391. strbuf.h
  392. streaming.c
  393. streaming.h
  394. string-list.c
  395. string-list.h
  396. strmap.c
  397. strmap.h
  398. strvec.c
  399. strvec.h
  400. sub-process.c
  401. sub-process.h
  402. submodule-config.c
  403. submodule-config.h
  404. submodule.c
  405. submodule.h
  406. symlinks.c
  407. tag.c
  408. tag.h
  409. tar.h
  410. tempfile.c
  411. tempfile.h
  412. thread-utils.c
  413. thread-utils.h
  414. tmp-objdir.c
  415. tmp-objdir.h
  416. trace.c
  417. trace.h
  418. trace2.c
  419. trace2.h
  420. trailer.c
  421. trailer.h
  422. transport-helper.c
  423. transport-internal.h
  424. transport.c
  425. transport.h
  426. tree-diff.c
  427. tree-walk.c
  428. tree-walk.h
  429. tree.c
  430. tree.h
  431. unicode-width.h
  432. unimplemented.sh
  433. unix-socket.c
  434. unix-socket.h
  435. unpack-trees.c
  436. unpack-trees.h
  437. upload-pack.c
  438. upload-pack.h
  439. url.c
  440. url.h
  441. urlmatch.c
  442. urlmatch.h
  443. usage.c
  444. userdiff.c
  445. userdiff.h
  446. utf8.c
  447. utf8.h
  448. varint.c
  449. varint.h
  450. version.c
  451. version.h
  452. versioncmp.c
  453. walker.c
  454. walker.h
  455. wildmatch.c
  456. wildmatch.h
  457. worktree.c
  458. worktree.h
  459. wrap-for-bin.sh
  460. wrapper.c
  461. write-or-die.c
  462. ws.c
  463. wt-status.c
  464. wt-status.h
  465. xdiff-interface.c
  466. xdiff-interface.h
  467. zlib.c
README.md

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just “subscribe git” in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the “What's cooking” reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name “git” was given by Linus Torvalds when he wrote the very first version. He described the tool as “the stupid content tracker” and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of “get” may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • “global information tracker”: you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • “goddamn idiotic truckload of sh*t”: when it breaks