tree 662e00673b62495221049c3bd2dd556bbcd77355
parent e885a84f1bc660adfc1dea5f6c25d0a92c7c9dbc
author Jeff King <peff@peff.net> 1601468912 -0400
committer Junio C Hamano <gitster@pobox.com> 1601495627 -0700

env--helper: write to opt->value in parseopt helper

We use OPT_CALLBACK_F() to call the option_parse_type() callback,
passing it the address of "cmdmode" as the value to write to. But the
callback doesn't look at opt->value at all, and instead writes to a
global variable.

This works out because that's the same global variable we happen to pass
in, but it's rather confusing.  Let's use the passed-in value instead.
We'll also make "cmdmode" a local variable of the main function,
ensuring we can't make the same mistake again.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>