)]}'
{
  "commit": "ac900fddb7fd3cc760ea5c1b79a50ad4564e4a0d",
  "tree": "de9480180f8ff9baf60942dd020c2e54e62371b3",
  "parents": [
    "98a136474082cdc7228d7e0e45672c5274fab701"
  ],
  "author": {
    "name": "Martin Ågren",
    "email": "martin.agren@gmail.com",
    "time": "Mon Aug 10 21:47:48 2020 +0200"
  },
  "committer": {
    "name": "Junio C Hamano",
    "email": "gitster@pobox.com",
    "time": "Mon Aug 10 14:59:57 2020 -0700"
  },
  "message": "progress: don\u0027t dereference before checking for NULL\n\nIn `stop_progress()`, we\u0027re careful to check that `p_progress` is\nnon-NULL before we dereference it, but by then we have already\ndereferenced it when calling `finish_if_sparse(*p_progress)`. And, for\nwhat it\u0027s worth, we\u0027ll go on to blindly dereference it again inside\n`stop_progress_msg()`.\n\nWe could return early if we get a NULL-pointer, but let\u0027s go one step\nfurther and BUG instead. The progress API handles NULL just fine, but\nthat\u0027s the NULL-ness of `*p_progress`, e.g., when running with\n`--no-progress`. If `p_progress` is NULL, chances are that\u0027s a mistake.\nFor symmetry, let\u0027s do the same check in `stop_progress_msg()`, too.\n\nSigned-off-by: Martin Ågren \u003cmartin.agren@gmail.com\u003e\nSigned-off-by: Junio C Hamano \u003cgitster@pobox.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6d2dcff0b6920037463f217d3d699305e8ccc491",
      "old_mode": 33188,
      "old_path": "progress.c",
      "new_id": "66ad941cf6b828124077e979830b390251315302",
      "new_mode": 33188,
      "new_path": "progress.c"
    }
  ]
}