)]}'
{
  "commit": "ae0780def7353ec713a96ef498d10e4ef70692a2",
  "tree": "52b256213cb581cf5d8dc6a614dccb9b98a3dd0b",
  "parents": [
    "e9019fcafe0040228b8631c30f97ae1adb61bcdc"
  ],
  "author": {
    "name": "Jeff King",
    "email": "peff@peff.net",
    "time": "Sun Jul 26 04:37:27 2026 -0400"
  },
  "committer": {
    "name": "Junio C Hamano",
    "email": "gitster@pobox.com",
    "time": "Sun Jul 26 09:36:17 2026 -0700"
  },
  "message": "bloom: silence CHECK_ASSERTION_SIDE_EFFECTS false positive\n\nUsing gcc 15, compiling with CHECK_ASSERTION_SIDE_EFFECTS\u003d1 causes a\ncomplaint about this line in bloom.c having a side effect:\n\n\tassert(version \u003d\u003d 1 || version \u003d\u003d 2);\n\nI think this is pretty clearly a false positive, as those comparisons\nshould not have side effects. The side-effect checker uses a magic\ndefinition of assert() that relies on the compiler\u0027s optimizer to drop a\nreference to an otherwise unused variable. And for whatever reason, gcc\nchooses not to do so here under -O2 (side note: if you have -O0 in your\nCFLAGS, that naturally creates many more false positives!).\n\nThis code has been around for a while, but nobody seems to have noticed\nbecause we use an older version of the compiler in our static-analysis\nci job, and it does not complain. Presumably very few people run this\ncheck locally on their more modern compilers.\n\nLet\u0027s silence the false positive to avoid confusion for anyone running\nlocally, and to make it possible to upgrade the image we use for our\nstatic-analysis job.\n\nWe could just switch to our custom ASSERT() here, but I think we can\nimprove the code by integrating the assertion into the if/else cascade.\nThat avoids repeating the logic about which versions are acceptable.\n\nSigned-off-by: Jeff King \u003cpeff@peff.net\u003e\nSigned-off-by: Junio C Hamano \u003cgitster@pobox.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a805ac0c296b37754f43bf0ce29af9ba19e76ea0",
      "old_mode": 33188,
      "old_path": "bloom.c",
      "new_id": "aac8f448c9fc9577bc463c5b591b7e2814e3726e",
      "new_mode": 33188,
      "new_path": "bloom.c"
    }
  ]
}