tree d7ddc14cf2d77d2a9a467ce6e2c83dece7618fcb
parent 74b052f8c269ef0b6f61a5ecf04a8568399345d9
author Matheus Tavares <matheus.bernardino@usp.br> 1601337713 -0300
committer Junio C Hamano <gitster@pobox.com> 1601340113 -0700

packfile: fix memory leak in add_delta_base_cache()

When add_delta_base_cache() is called with a base that is already in the
cache, no operation is performed. But the check is done after allocating
space for a new entry, so we end up leaking memory on the early return.
In addition, the caller never free()'s the base as it expects the
function to take ownership of it. But the base is not released when we
skip insertion, so it also gets leaked. To fix these problems, move the
allocation of a new entry further down in add_delta_base_cache(), and
free() the base on early return.

Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
Signed-off-by: Junio C Hamano <gitster@pobox.com>