t5516: Use test_cmp when appropriate
Consistently using test_cmp would make debugging test scripts far easier,
as output from them run under "-v" option becomes readable.
Besides, some platforms' "diff" implementations lack "-q" option.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
index 11adb0b..2de98e6 100755
--- a/t/t5516-fetch-push.sh
+++ b/t/t5516-fetch-push.sh
@@ -672,7 +672,7 @@
test "z$r" = "z$the_commit" &&
test 1 = $(git for-each-ref refs/remotes/origin | wc -l)
) &&
- diff -q .git/foo .git/bar
+ test_cmp .git/foo .git/bar
'
test_expect_success 'push --porcelain bad url' '
@@ -692,7 +692,7 @@
echo >>.git/foo "! refs/heads/master:refs/heads/master [remote rejected] (branch is currently checked out)" &&
test_must_fail git push >.git/bar --porcelain testrepo refs/heads/master:refs/heads/master &&
- diff -q .git/foo .git/bar
+ test_cmp .git/foo .git/bar
'
test_expect_success 'push --porcelain --dry-run rejected' '
@@ -707,7 +707,7 @@
echo >>.git/foo "Done" &&
test_must_fail git push >.git/bar --porcelain --dry-run testrepo refs/heads/master^:refs/heads/master &&
- diff -q .git/foo .git/bar
+ test_cmp .git/foo .git/bar
'
test_done
