commit e6c64fc1e9b3b9a5ea7101f8a2a499c9e2112da5
author Junio C Hamano <junkio@cox.net> Sat Nov 05 11:02:56 2005 -0800
committer Junio C Hamano <junkio@cox.net> Sat Nov 05 11:02:56 2005 -0800
tree 13db03ab4c21816447ba0f9ea9fe339e29cb7887
parent 28ffb8987af97e28accc707c724207fbd745b027

copy.c::copy_fd() - do not leak file descriptor on error return.

Signed-off-by: Junio C Hamano <junkio@cox.net>

copy.c

diff --git a/copy.c b/copy.c
index 2009275..e1cd5d0 100644
--- a/copy.c
+++ b/copy.c
@@ -10,10 +10,13 @@
 		if (!len)
 			break;
 		if (len < 0) {
+			int read_error;
 			if (errno == EAGAIN)
 				continue;
+			read_error = errno;
+			close(ifd);
 			return error("copy-fd: read returned %s",
-				     strerror(errno));
+				     strerror(read_error));
 		}
 		while (1) {
 			int written = write(ofd, buf, len);