fix(spanner): handle unused errors (#10067)
The error return values were not being used. Caught by staticcheck.
diff --git a/spanner/spansql/parser.go b/spanner/spansql/parser.go
index d7b7e4e..982b6d1 100644
--- a/spanner/spansql/parser.go
+++ b/spanner/spansql/parser.go
@@ -1372,6 +1372,9 @@
return nil, err
}
vname, err := p.parseTableOrIndexOrColumnName()
+ if err != nil {
+ return nil, err
+ }
if err := p.expect("SQL", "SECURITY"); err != nil {
return nil, err
}
diff --git a/spanner/test/cloudexecutor/executor/actions/admin.go b/spanner/test/cloudexecutor/executor/actions/admin.go
index b2b4308..d9421fe 100644
--- a/spanner/test/cloudexecutor/executor/actions/admin.go
+++ b/spanner/test/cloudexecutor/executor/actions/admin.go
@@ -347,6 +347,9 @@
instanceObj, err := instanceAdminClient.GetInstance(ctx, &instancepb.GetInstanceRequest{
Name: fmt.Sprintf("projects/%s/instances/%s", projectID, instanceID),
})
+ if err != nil {
+ return err
+ }
spannerActionOutcome := &executorpb.SpannerActionOutcome{
Status: &spb.Status{Code: int32(codes.OK)},
AdminResult: &executorpb.AdminResult{
diff --git a/spanner/test/cloudexecutor/executor/actions/mutation.go b/spanner/test/cloudexecutor/executor/actions/mutation.go
index 1135872..f334b4b 100644
--- a/spanner/test/cloudexecutor/executor/actions/mutation.go
+++ b/spanner/test/cloudexecutor/executor/actions/mutation.go
@@ -139,6 +139,9 @@
return nil, err
}
keySet, err := utility.KeySetProtoToCloudKeySet(mod.DeleteKeys, keyColTypes)
+ if err != nil {
+ return nil, err
+ }
m = append(m, spanner.Delete(table, keySet))
default:
return nil, spanner.ToSpannerError(status.Errorf(codes.InvalidArgument, "unsupported mod: %s", mod.String()))
