tree cb0c8b3d3f42e0d30c8a6e2cc157d7546b743fbd
parent 6d96a602dff73fe1e094e1fe1d8539f5d70367cb
author Jean de Klerk <deklerk@google.com> 1543547516 -0500
committer Jean de Klerk <deklerk@google.com> 1544131853 +0000

firestore: allow StartAt/EndBefore on direct children at any depth

In firestore, it is legal to construct a query with a StartAt or EndBefore
filter. These accept document snapshots (snaps) as input parameters. If a snap
is passed, that snap must be a direct child of the location being queried.

However, the current implementation has a bug that only allows children of
documents at depth=1 to be specified: an extra /documents/ gets added to the
collectionPath of each collection: e.g. querying /c1/d1/c2 with StartAt at
/c1/d1/c2/d2 resulted in an incorrect path
/database/some-db/c1/d1/c2/documents/d2. It should be
/database/some-db/documents/c1/d1/c2/d2.

So, despite being a valid StartAt value, the user experiences an error. This CL
fixes that issue.

Finally, some documentation was updated to make all this behavior more clear.

Fixes #1225

Change-Id: I7f467701d5ccf4b5a77bb3c4b1960e6ef173dfb3
Reviewed-on: https://code-review.googlesource.com/c/35790
Reviewed-by: Eno Compton <enocom@google.com>