tree 8071b7c74f80ccefca2cebe04a603bb6695ebb37
parent cc13a9bec59f97f8ea60047fedd3005668851a70
author Jonathan Amsterdam <jba@google.com> 1489023661 -0500
committer Jonathan Amsterdam <jba@google.com> 1489160636 +0000

pubsub: check early if streaming iterator is already drained

Fix the fake streaming server to behave more realistically, by waiting
for a CloseSend from the client before ending the stream.

This revealed that the streaming iterator has an unnecessary delay,
due to the stop method blocking on the channel when there were no more
messages. So we now check that case before reading from the channel.

Also, s/Skip/SkipNow/ in tests.

Change-Id: Iacd826c07f6d327475c69e5002cab2381e47d9a5
Reviewed-on: https://code-review.googlesource.com/11374
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Michael Darakananda <pongad@google.com>
Reviewed-by: Kamal Aboul-Hosn <aboulhosn@google.com>