tree 744082aae601310d070ee2cacabdea5a7869a9a7
parent 4c9ee5237a4cbfbea72dec00eacb434cc2d1b697
author David Symonds <dsymonds@golang.org> 1583808876 +1100
committer David Symonds <dsymonds@golang.org> 1583838109 +0000

spanner/spannertest: fix data race in query execution

Whenever a table is used as the data source for a query (most SELECT
statements), the table needs to be completely read before evalSelect
returns, since that is what holds the table lock. The prior code
erroneously only did that when the outermost rowIter was a tableIter,
when that is in fact never the case. The correct approach is to flatten
the output rowIter whenever a tableIter is used as a data source.

Change-Id: I21e26ad06e7c2bb295c583d2a34178122cd2b5c1
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/52995
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Knut Olav Løite <koloite@gmail.com>