tree fbd81dad7551719234bfbb3b8b86dbe6fd2b862f
parent 3bec1e11d6972bd04fd9a0ecbd4fcff0f5810439
author Jean de Klerk <deklerk@google.com> 1545268505 -0800
committer Jean de Klerk <deklerk@google.com> 1545995532 +0000

spanner: correctly allow MinOpened sessions to be spun up

Session maintainer incorrectly uses the channel returned by time.After in two
select statements. However, time.After does not _close_ the channel, it
_signals_ the channel: so, only one select statement catches the signal.
This CL changes the behavior to use a context.WithTimeout instead, which does
get closed (ctx.Done).

Also moves shrinkPool and replenishPool into their own methods.

Fixes #1259

Change-Id: Ide2e417ca51ea9bc2416bde5e19d82defe427da6
Reviewed-on: https://code-review.googlesource.com/c/36711
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>