tree abd20b4a7ab297e03444bc5c8abc8ca320190ee0
parent 19bd677aa6bb6ef961ed11383087562781931490
author Jean de Klerk <deklerk@google.com> 1551819469 -0700
committer Jean de Klerk <deklerk@google.com> 1551895825 +0000

internal: create sponge.xml even in failure case

Currently, `set -eo pipefail` causes presubmit.sh/continuous.sh to exit
as soon as `go test ./...` fails. That is, in the failure case we never
reach the final step, which is to take the raw output log and create a
sponge.xml from it.

This change makes the finalization step of creating a sponge.xml its own
function, and adds a trap statement to trigger cleanup on EXIT (0 -
success) and ERR (1 - failure).

See https://sponge.corp.google.com/invocation?tab=Build+Log&id=d689492c-bdb5-4d0c-8755-7bd92a651d93&searchFor=
for an example of a test failure with this change. Note that logs are emitted
to stdout _and_ test targets are recorded in sponge.

Relevant internal bug: 126600670

Change-Id: I32e6b5c6e1bd907aefea9150d96460ad8152b191
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/38710
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexey Alexandrov <aalexand@google.com>