)]}' { "commit": "f5990a4292826db021c86aa413b5149cc714a78f", "tree": "75c5f21874f5a9563df53c0a01801ee48229bcb4", "parents": [ "3b9ae547b3d80df7227c0e71bc60c86aee8c4b89" ], "author": { "name": "Tyler Bui-Palsulich", "email": "tbp@google.com", "time": "Tue Dec 04 12:26:09 2018 -0800" }, "committer": { "name": "Tyler Bui-Palsulich", "email": "tbp@google.com", "time": "Tue Dec 04 23:39:31 2018 +0000" }, "message": "functions: don\u0027t use a wrapper and make Resource a value\n\nWe\u0027ll switch Resource back to a pointer after the next worker release.\n\nThe wrapper doesn\u0027t work because the JSON is provided by the worker.\nThe worker does not include the wrapper. So, we end up with a mismatch:\n\n with wrapper: {\"m\":{\"eventId\":\"test event ID\",\"timestamp\":\"0001-01-01T00:00:00Z\",\"eventType\":\"\",\"resource\":null}}\n\n no wrapper: {\"eventId\":\"test event ID\",\"timestamp\":\"0001-01-01T00:00:00Z\",\"eventType\":\"\",\"resource\":null}\n\nMaking testing easier is not enough of a reason to add the additional\nlayer of indirection in the JSON with the wrapper.\n\nChange-Id: Ifcd3df6f82377f8ddacd6621be8e759cf5a2b44c\nReviewed-on: https://code-review.googlesource.com/c/36070\nReviewed-by: Chris Broadfoot \u003ccbro@google.com\u003e\nReviewed-by: Jean de Klerk \u003cdeklerk@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "6f4120dda8400fe35ca402e579c78f8030f782f9", "old_mode": 33188, "old_path": "functions/metadata/metadata.go", "new_id": "26f4434811d4e104ef2b2a3a102642280ea5eb57", "new_mode": 33188, "new_path": "functions/metadata/metadata.go" }, { "type": "modify", "old_id": "065c3792ff75a826cb1de94c8369b019823b46da", "old_mode": 33188, "old_path": "functions/metadata/metadata_test.go", "new_id": "9f9d2e51c65b24f48923aaab4d63bf85fa0b5f92", "new_mode": 33188, "new_path": "functions/metadata/metadata_test.go" } ] }