pubsub: reduce allocations when calculating ackDeadline

Instead of allocating a new slice to save monotonically
increasing sums on every invocation of (*D).Percentile,
on every invocation of New(n) to create a new D, we
allocate a []uint64 slice that will be used to store the
monotonically increasing sums thus avoiding that recomputation
every single time.

This change removes all allocations in (*D).Percentile.

name            old time/op    new time/op    delta
Distribution-8    1.68µs ± 3%    0.95µs ± 3%   -43.39%  (p=0.008 n=5+5)

name            old alloc/op   new alloc/op   delta
Distribution-8    8.19kB ± 0%    0.00kB       -100.00%  (p=0.008 n=5+5)

name            old allocs/op  new allocs/op  delta
Distribution-8      1.00 ± 0%      0.00       -100.00%  (p=0.008 n=5+5)

Fixes #1538

Change-Id: I421cf856bd16263b36117c2a7eece3df8c832773
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/44291
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
2 files changed
tree: c66294526040eb449f7e7d1f742fc112f7214c03
  1. CHANGES.md
  2. CODE_OF_CONDUCT.md
  3. CONTRIBUTING.md
  4. LICENSE
  5. README.md
  6. RELEASING.md
  7. asset/
  8. automl/
  9. bigquery/
  10. bigtable/
  11. civil/
  12. cloud.go
  13. cloudtasks/
  14. cmd/
  15. compute/
  16. container/
  17. containeranalysis/
  18. dataproc/
  19. datastore/
  20. debugger/
  21. dialogflow/
  22. dlp/
  23. errorreporting/
  24. examples_test.go
  25. expr/
  26. firestore/
  27. functions/
  28. go.mod
  29. go.sum
  30. grafeas/
  31. httpreplay/
  32. iam/
  33. internal/
  34. iot/
  35. irm/
  36. issue_template.md
  37. kms/
  38. language/
  39. license_test.go
  40. logging/
  41. longrunning/
  42. monitoring/
  43. oslogin/
  44. phishingprotection/
  45. profiler/
  46. pubsub/
  47. recaptchaenterprise/
  48. redis/
  49. regen-gapic.sh
  50. rpcreplay/
  51. scheduler/
  52. securitycenter/
  53. spanner/
  54. speech/
  55. storage/
  56. talent/
  57. texttospeech/
  58. tidyall.sh
  59. tools.go
  60. trace/
  61. translate/
  62. videointelligence/
  63. vision/
  64. webrisk/
README.md

Google Cloud Client Libraries for Go

GoDoc

Go packages for Google Cloud Platform services.

import "cloud.google.com/go"

To install the packages on your system, do not clone the repo. Instead use

$ go get -u cloud.google.com/go/...

NOTE: Some of these packages are under development, and may occasionally make backwards-incompatible changes.

NOTE: Github repo is a mirror of https://code.googlesource.com/gocloud.

Supported APIs

Google APIStatusPackage
Assetalphacloud.google.com/go/asset/v1beta
BigQuerystablecloud.google.com/go/bigquery
Bigtablestablecloud.google.com/go/bigtable
Cloudtasksstablecloud.google.com/go/cloudtasks/apiv2
Containerstablecloud.google.com/go/container/apiv1
ContainerAnalysisbetacloud.google.com/go/containeranalysis/apiv1beta1
Dataprocstablecloud.google.com/go/dataproc/apiv1
Datastorestablecloud.google.com/go/datastore
Debuggeralphacloud.google.com/go/debugger/apiv2
Dialogflowalphacloud.google.com/go/dialogflow/apiv2
Data Loss Preventionalphacloud.google.com/go/dlp/apiv2
ErrorReportingalphacloud.google.com/go/errorreporting
Firestorestablecloud.google.com/go/firestore
IAMstablecloud.google.com/go/iam
IoTalphacloud.google.com/iot/apiv1
KMSstablecloud.google.com/go/kms
Natural Languagestablecloud.google.com/go/language/apiv1
Loggingstablecloud.google.com/go/logging
Monitoringalphacloud.google.com/go/monitoring/apiv3
OS Loginalphacloud.google.com/go/oslogin/apiv1
Pub/Substablecloud.google.com/go/pubsub
Phishing Protectionalphacloud.google.com/go/phishingprotection/apiv1betad1
reCAPTCHA Enterprisealphacloud.google.com/go/recaptchaenterprise/apiv1betad1
Memorystorealphacloud.google.com/go/redis/apiv1
Schedulerstablecloud.google.com/go/scheduler/apiv1
Spannerstablecloud.google.com/go/spanner
Speechstablecloud.google.com/go/speech/apiv1
Storagestablecloud.google.com/go/storage
Talentalphacloud.google.com/go/talent/apiv4beta1
Text To Speechalphacloud.google.com/go/texttospeech/apiv1
Tracealphacloud.google.com/go/trace/apiv2
Translatestablecloud.google.com/go/translate
Video Intelligencealphacloud.google.com/go/videointelligence/apiv1beta1
Visionstablecloud.google.com/go/vision/apiv1

Alpha status: the API is still being actively developed. As a result, it might change in backward-incompatible ways and is not recommended for production use.

Beta status: the API is largely complete, but still has outstanding features and bugs to be addressed. There may be minor backwards-incompatible changes where necessary.

Stable status: the API is mature and ready for production use. We will continue addressing bugs and feature requests.

Documentation and examples are available at godoc.org/cloud.google.com/go

Go Versions Supported

We support the two most recent major versions of Go. If Google App Engine uses an older version, we support that as well.

Authorization

By default, each API will use Google Application Default Credentials for authorization credentials used in calling the API endpoints. This will allow your application to run in many environments without requiring explicit configuration.

client, err := storage.NewClient(ctx)

To authorize using a JSON key file, pass option.WithCredentialsFile to the NewClient function of the desired package. For example:

client, err := storage.NewClient(ctx, option.WithCredentialsFile("path/to/keyfile.json"))

You can exert more control over authorization by using the golang.org/x/oauth2 package to create an oauth2.TokenSource. Then pass option.WithTokenSource to the NewClient function: snip:# (auth-ts)

tokenSource := ...
client, err := storage.NewClient(ctx, option.WithTokenSource(tokenSource))

Contributing

Contributions are welcome. Please, see the CONTRIBUTING document for details. We‘re using Gerrit for our code reviews. Please don’t open pull requests against this repo, new pull requests will be automatically closed.

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms. See Contributor Code of Conduct for more information.