tree edf2e3701773039807eb796f53d496d859b4e9f7
parent 9a7bb2b9c4403c8fb5c414faefb2bb74da666923
author Chris Cotter <cjcotter@google.com> 1592338098 -0400
committer GitHub <noreply@github.com> 1592338098 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJe6SayCRBK7hj4Ov3rIwAAdHIIAB0HeL7D8ruL48uED8sQYqh2
 8LNVPt5NPz46182r46ZEQjLAcxx9YMjVO52vuxfnIPSFup2YwmrtRrB7l1NrE4Kd
 I8F9TFNLJOq1/NsUBEowKqarwCMaWqYZCYFZKC7GUqyQcII9nG+5Ge3e77RLw1XE
 UtE9vRL/ABCsR9XIsbXob6V7ttlIy650Rv4lNtr/qKDtZKuFRsSXCituqGQv0r7x
 9C7bfxNdU3CyxNqw19RG+b4VoRykICl4pXKIf1MngDAwhzJM31uRv+P7yJe8QC7Y
 BwTHzKQrkfy4TJ91mWJY3jUq3iQ/wKmb2MjL9oxWOk/ZpNUoNGfCz6iRNPEZ6kA=
 =Sm6N
 -----END PGP SIGNATURE-----
 

transport/http: don't reuse a base transport between clients (#532)

Previously sync.Once was used to cache a fallback base transport.
This caused a race condition when setting MaxIdleConnsPerHost
and TLSClientConfig in defaultBaseTransport (above). Because of these
settings, it isn't valid to share the base transport across clients.

I conferred with @neild and determined that it is impossible to implement a
transport.Clone for < Go 1.13, so instead we should initialize
a new transport with default values each time in this case.

Fixes googleapis/google-cloud-go#2405