| commit | 4fac4de465568dff4e9b2a31b4d7a1da4ba2cefb | [log] [tgz] |
|---|---|---|
| author | Jean de Klerk <deklerk@google.com> | Wed Aug 14 10:23:48 2019 -0600 |
| committer | Jean de Klerk <deklerk@google.com> | Mon Aug 19 15:01:41 2019 +0000 |
| tree | 32cfb9517733b25e5c67cefd24d91ff6f4be7e02 | |
| parent | 573115b31dcba90b19c25508412495d63f86e804 [diff] |
all: add per-chunk retry deadline In https://code-review.googlesource.com/c/google-api-go-client/+/43470, we accidentally removed a piece of logic that gave each chunk* a deadline. This adds it back. This CL also adds tests for retry logic, so that we don't miss it next time. This CL also removes contextDone(ctx context.Context) bool, since it's only used in one place, and in that one place we do the exact same logic right after contextDone is used. * Note: the single for loop in the aforementioned CL is not a for loop that only handles retries for "each chunk". That for loop handles both retries as well as multiple chunks (which could occur by way of incomplete transfers). When a new chunk was started, the for loop wasn't quit: instead, the backoff and retryDeadline was re-initialized. In this CL, that single for loop is split into an outer (per chunk) and inner (retry for a single chunk) for loop. Subsequently the backoff/retry reset logic is removed. This makes it more clear what's happening. Fixes #389 Change-Id: Ib66905efb5eaca5f9a40dccd343bff7c7d2b5aa3 Reviewed-on: https://code-review.googlesource.com/c/google-api-go-client/+/44070 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Tyler Bui-Palsulich <tbp@google.com>
$ go get google.golang.org/api/tasks/v1 $ go get google.golang.org/api/moderator/v1 $ go get google.golang.org/api/urlshortener/v1 ... etc ...
and using:
package main import ( "net/http" "google.golang.org/api/urlshortener/v1" ) func main() { svc, err := urlshortener.New(http.DefaultClient) // ... }
These are auto-generated Go libraries from the Google Discovery Service's JSON description files of the available “new style” Google APIs.
Due to the auto-generated nature of this collection of libraries, complete APIs or specific versions can appear or go away without notice. As a result, you should always locally vendor any API(s) that your code relies upon.
These client libraries are officially supported by Google. However, the libraries are considered complete and are in maintenance mode. This means that we will address critical bugs and security issues but will not add any new features.
If you're working with Google Cloud Platform APIs such as Datastore or Pub/Sub, consider using the Cloud Client Libraries for Go instead. These are the new and idiomatic Go libraries targeted specifically at Google Cloud Platform Services.
The generator itself and the code it produces are beta. Some APIs are alpha/beta, and indicated as such in the import path (e.g., “google.golang.org/api/someapi/v1alpha”).
Application Default Credentials provide a simplified way to obtain credentials for authenticating with Google APIs.
The Application Default Credentials authenticate as the application itself, which make them great for working with Google Cloud APIs like Storage or Datastore. They are the recommended form of authentication when building applications that run on Google Compute Engine or Google App Engine.
Default credentials are provided by the golang.org/x/oauth2/google package. To use them, add the following import:
import "golang.org/x/oauth2/google"
Some credentials types require you to specify scopes, and service entry points may not inject them. If you encounter this situation you may need to specify scopes as follows:
import ( "context" "golang.org/x/oauth2/google" "google.golang.org/api/compute/v1" ) func main() { // Use oauth2.NoContext if there isn't a good context to pass in. ctx := context.Background() client, err := google.DefaultClient(ctx, compute.ComputeScope) if err != nil { //... } computeService, err := compute.New(client) if err != nil { //... } }
If you need a oauth2.TokenSource, use the DefaultTokenSource function:
ts, err := google.DefaultTokenSource(ctx, scope1, scope2, ...) if err != nil { //... } client := oauth2.NewClient(ctx, ts)
See also: golang.org/x/oauth2/google package documentation.