tree 1c6a3d31f9d6af283dd7ce6125e2a96417ec2b55
parent f9718892c732c484b97d9a879482a9441f753932
author Jean de Klerk <deklerk@google.com> 1546881675 -0800
committer Jean de Klerk <deklerk@google.com> 1546979148 +0000

internal: fix new staticcheck warnings

- The staticchecker we use seems to have gotten upgrades that allows it to find
a bunch more things to clean up - mostly unused vars/methods/etc. This CL
does the needful fixing-up.
- Also switches from using -ignore to using ye olde pipe-stderr-to-stdout-and-
grep-exclude since -ignore is being deprecated. Subsequently we have to remove
pipefail, since we now expect staticcheck's exit code to be 1.

Change-Id: Ife74520c39db4208ca1347ef97643365a370c7af
Reviewed-on: https://code-review.googlesource.com/c/37070
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Eno Compton <enocom@google.com>