tree c04c982775f8d082b1fd72291c444c7a8b9e82bc
parent d708bdaa52e7a6d12efa371d241639933f1455fb
author Dan Scales <danscales@google.com> 1572649447 -0700
committer Dan Scales <danscales@google.com> 1572891185 +0000

bundler: stop timer from waiting for flushed requests to be handled

The timer used to flush an un-full bundler happens to call b.Flush(), which
includes a wait until all the outstanding bundles included the just-flushed one
have been handled. But there doesn't seem to be any reason for the timer to do the
wait, since it doesn't do anything after the wait. So, change the timer call to
use a new flushWithoutWait() method. For certain workloads, this change should
reduce the number of timer threads waiting around and being repeatedly woken up by
broadcasts on the b.cond condition variable.

Testing:  bundler tests, pubsub tests (in gcloud repo, but using this bundler change),
and pubsub loadtest.  Let me know if there is anything else I should run.

Change-Id: I656479ebfa914d10ac0bac5f65c3e68f7f40187c
Reviewed-on: https://code-review.googlesource.com/c/google-api-go-client/+/47790
Reviewed-by: Dan Scales <danscales@google.com>