tree d6a3a74b0d3948afb3fa0fa351c3d0e9ec0613bc
parent 3d82a3b2e4197d731f8b34baa41f0dd62ba5f8d3
author Seth Hollyman <shollyman@google.com> 1569434084 +0000
committer Seth Hollyman <shollyman@google.com> 1572281685 +0000

google-api-go-generator: generalize media path replacement

This change improves media path handling when dealing with API
methods that support multipart media upload.

By convention, most APIs at Google leverage an /upload/ alternate
prefix path to do with multipart requests, as they rely on a common
infrastructure component that uses this convention.  This removes
special path replacement behavior by simply leveraging the
supplied media path as expressed in the discovery doc reference:

https://developers.google.com/discovery/v1/reference/apis

This has the effect of allowing APIs to generate correctly
when using hostnames other than www.googleapis.com as the root
URL, which previous behavior relied upon.

This PR also updates tests, as there were a lot of implicit
behaviors that don't reflect proper usage.

For example, while under test the BasePath was frequently set
to the bare server.URL e.g. http://n.n.n.n:p/ which meant that
things like the prior redirect hack was ignored entirely.

This change also adds a test for googleapi.ResolveRelative to
ensure this path replacement behavior is preserved for future
maintainers.

Change-Id: Icbc9bccf9f168f6c78d17b7feab6d82c6a4a1199
Reviewed-on: https://code-review.googlesource.com/c/google-api-go-client/+/46011
Reviewed-by: Chris Broadfoot <cbro@google.com>
Reviewed-by: kokoro <noreply+kokoro@google.com>