tree cb8b5c8141cf19c8d7869c6171450e0115de770c
parent 93f710e7c7e7f084a7043ec18aab7359e7626811
author Dave Day <djd@golang.org> 1472189767 +1000
committer Dave Day <djd@golang.org> 1472518412 +0000

googleapi: use RawPath, not Opaque, for template expansion

Historically the google-api-go-client has had trouble sending certain
characters in paths without the Go standard library (net/url and
net/http packages) double escaping or escaping in an unexpected manner
(for example, space encoding in issue #64).

As a workaround, we started escaping the URL manually and using
url.Opaque (for example, 02cfcab and 5c258d4). This mostly works but has
problems with HTTP/2 (golang/go#16847). In Go 1.5, the URL struct
introduced the RawPath field which was more suitable for this task: if
RawPath is provided and is a valid escaping of Path, then the url
package will use it as the value of EscapedPath (and EscapedPath is then
subsequently used when constructing HTTP requests etc.).

This commit changes uritemplates.Expand to return both the unescaped and
escaped forms of the the template expansion. This allows us to fill in
both url.Path and url.RawPath in a way that satisfies the criteria for
url.EscapedPath to function correctly.

Issue #161.

Change-Id: I51e54e18f198b6465a6d032b1072282bf3d2f9ce
Reviewed-on: https://code-review.googlesource.com/7110
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>