)]}' { "commit": "6f47ed6cd12a0ea9b55b19b5d6e4a3b490a97bdf", "tree": "40ded442b07adb209ccbadac84005d8a91165579", "parents": [ "27adafcda3d8b8a818e85d58eea95b85b5f513f9" ], "author": { "name": "Namhyung Kim", "email": "namhyung@kernel.org", "time": "Tue Sep 15 12:18:17 2020 +0900" }, "committer": { "name": "Arnaldo Carvalho de Melo", "email": "acme@redhat.com", "time": "Tue Sep 15 09:22:21 2020 -0300" }, "message": "perf metric: Do not free metric when failed to resolve\n\nIt\u0027s dangerous to free the original metric when it\u0027s called from\nresolve_metric() as it\u0027s already in the metric_list and might have other\nresources too. Instead, it\u0027d better let them bail out and be released\nproperly at the later stage.\n\nSo add a check when it\u0027s called from metricgroup__add_metric() and\nrelease it. Also make sure that mp is set properly.\n\nFixes: 83de0b7d535de (\"perf metric: Collect referenced metrics in struct metric_ref_node\")\nSigned-off-by: Namhyung Kim \u003cnamhyung@kernel.org\u003e\nAcked-by: Jiri Olsa \u003cjolsa@redhat.com\u003e\nCc: Alexander Shishkin \u003calexander.shishkin@linux.intel.com\u003e\nCc: Andi Kleen \u003cak@linux.intel.com\u003e\nCc: Ian Rogers \u003cirogers@google.com\u003e\nCc: Mark Rutland \u003cmark.rutland@arm.com\u003e\nCc: Peter Zijlstra \u003cpeterz@infradead.org\u003e\nCc: Stephane Eranian \u003ceranian@google.com\u003e\nLink: http://lore.kernel.org/lkml/20200915031819.386559-10-namhyung@kernel.org\nSigned-off-by: Arnaldo Carvalho de Melo \u003cacme@redhat.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "c8904e471a71efed0d839640a1d2bd17563c207f", "old_mode": 33188, "old_path": "tools/perf/util/metricgroup.c", "new_id": "ab5030fcfed4e2082c0472ee398ebb429d536a59", "new_mode": 33188, "new_path": "tools/perf/util/metricgroup.c" } ] }