)]}'
{
  "commit": "8a614f2b5d357b980ba63bac4a9dbd8955f23f23",
  "tree": "8a8eac0e9bfc4e2a64de1496bdd1fdb68b7bcb92",
  "parents": [
    "83f9672fc2b5462bc6a1c3dcf9b82d1326163987"
  ],
  "author": {
    "name": "Brett Johnson",
    "email": "Brett.Michael.Johnson@gmail.com",
    "time": "Tue Apr 01 12:09:41 2014 -0700"
  },
  "committer": {
    "name": "Brett Johnson",
    "email": "Brett.Michael.Johnson@gmail.com",
    "time": "Tue Apr 01 14:10:16 2014 -0700"
  },
  "message": "Fix Flakey Unit Tests\n\nThis change restores two unit tests that failed regularly\nwhen run under Windows.  Both of these tests time how long\nit takes to shutdown either the Application or the Service,\nand in both cases it took slightly longer than expected.\n\nI believe the timing constraints were too tight, especially\nfor ShutdownWaiterTest.testShutdownFullWait(), which told\nthe waiter to wait 50 milliseconds for the shutdown to\ncomplete and complained if it took more than 58 milliseconds.\nThis could be an issue if shutdown took many seconds, minutes,\nor forever, but taking 10 or 20 milliseconds longer to shutdown\nshould not really be considered a problem.\n\nBefore I disabled the test, shutdown was taking slightly more\nthan 58 milliseconds most of the time, with an occasional breach\nof 60 milliseconds when run on my Windows VM.  I bumped the\nceiling to 65 ms and could easily be convinced that 75 or 100 ms\nwould be acceptable.  I also replaced instances of \"Mu\" with\n\"microseconds\" in the error messages, since the character did\nnot display correctly in the windows shell.\n\nThe second flakey test, ApplicationTest.testFastShutdownWhenStarting(),\nI was unable to get it to fail again in 100 attempts.  I even\nran 2 instances of the Connector Manager coverage tests at the same\ntime, each of which pegs the CPUs.  I thought I would overheat the\nmachine with all 4 cores pegged for nearly an hour.  Therefore,\nI restored the test unchanged.  If it starts failing again, we\nshould address it then.\n\nCode Review: http://codereview.appspot.com/83000045\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "90d07f0cc8626e4fd30058e6d2e80fb665af7ee4",
      "old_mode": 33188,
      "old_path": "test/com/google/enterprise/adaptor/ApplicationTest.java",
      "new_id": "e30a728c8fe6139d71a3ab69ac6ae23dac7acb43",
      "new_mode": 33188,
      "new_path": "test/com/google/enterprise/adaptor/ApplicationTest.java"
    },
    {
      "type": "modify",
      "old_id": "38327e5e2417806e435fdc646a9e00a66aa66601",
      "old_mode": 33188,
      "old_path": "test/com/google/enterprise/adaptor/ShutdownWaiterTest.java",
      "new_id": "2da76dae9c1ab9457d40579b45dcbcd6e9367576",
      "new_mode": 33188,
      "new_path": "test/com/google/enterprise/adaptor/ShutdownWaiterTest.java"
    }
  ]
}