commit 9ab4d39926765d5a3ec350a01247438bc1192b99
author Eric Anderson <ejona@google.com> Fri Nov 22 09:46:51 2013 -0800
committer Eric Anderson <ejona@google.com> Fri Dec 20 16:40:40 2013 -0800
tree 6ac9004122591c14f7e4c2a0f20826d5eda437ec
parent 7bbcf1699d2a9cee6f213ba05e7bebf90c58be04

Prevent mutations to AdaptorContext after Adaptor.init()

This limitation has been the intention for a little while now, but many
cases were overlooked.

src/com/google/enterprise/adaptor/GsaCommunicationHandler.java

diff --git a/src/com/google/enterprise/adaptor/GsaCommunicationHandler.java b/src/com/google/enterprise/adaptor/GsaCommunicationHandler.java
index bfc11db..34b95db 100644
--- a/src/com/google/enterprise/adaptor/GsaCommunicationHandler.java
+++ b/src/com/google/enterprise/adaptor/GsaCommunicationHandler.java
@@ -868,11 +868,17 @@
 
     @Override
     public void addStatusSource(StatusSource source) {
+      if (afterInit) {
+        throw new IllegalStateException("After init()");
+      }
       dashboard.addStatusSource(source);
     }
 
     @Override
     public void setGetDocIdsFullErrorHandler(ExceptionHandler handler) {
+      if (afterInit) {
+        throw new IllegalStateException("After init()");
+      }
       ((PushRunnable) docIdFullPusher.getRunnable())
           .setGetDocIdsErrorHandler(handler);
     }
@@ -886,6 +892,9 @@
     @Override
     public void setGetDocIdsIncrementalErrorHandler(
         ExceptionHandler handler) {
+      if (afterInit) {
+        throw new IllegalStateException("After init()");
+      }
       ((PushRunnable) docIdFullPusher.getRunnable())
           .setGetDocIdsErrorHandler(handler);
     }
@@ -903,6 +912,9 @@
 
     @Override
     public HttpContext createHttpContext(String path, HttpHandler handler) {
+      if (afterInit) {
+        throw new IllegalStateException("After init()");
+      }
       return addFilters(scope.createContext(path, handler));
     }