commit 9ad4104dc6970b8ed9ae6660912d51355146cbe1
author Marc Kriguer <myk@google.com> Thu Dec 12 10:38:40 2013 -0800
committer Marc Kriguer <myk@google.com> Fri Dec 13 14:19:57 2013 -0800
tree 79c2ff781a8e80207d8f199d52d96cc360f38704
parent 67871c45adc51dd1dc8c1f7b5d6047df51d31618

Allow either user or password to be overridden

Current behavior:
* Default user and default password must be specified;
* Overriding both user and password for a given server is allowed;
* Overriding just the password for a given server is allowed;
* Overriding just the user for a given server gives an error.

New behavior:
* Default user and default password no longer needed.
* If a per-server user and/or password is specified, use it
  (otherwise, use the default).
* If the user and/or password is non-empty, throw the exception.

src/com/google/enterprise/adaptor/ad/AdAdaptor.java

diff --git a/src/com/google/enterprise/adaptor/ad/AdAdaptor.java b/src/com/google/enterprise/adaptor/ad/AdAdaptor.java
index f334fb5..df96e42 100644
--- a/src/com/google/enterprise/adaptor/ad/AdAdaptor.java
+++ b/src/com/google/enterprise/adaptor/ad/AdAdaptor.java
@@ -41,7 +41,7 @@
 
   private String namespace;
   private String defaultUser;  // used if an AD doesn't override
-  private String defaultPassword;
+  private String defaultPassword;  // likewise
   private List<AdServer> servers = new ArrayList<AdServer>();
   private Map<String, String> localizedStrings;
   private boolean feedBuiltinGroups;
@@ -50,8 +50,8 @@
   public void initConfig(Config config) {
     config.addKey("ad.servers", null);
     config.addKey("adaptor.namespace", "Default");
-    config.addKey("ad.defaultUser", null);
-    config.addKey("ad.defaultPassword", null);
+    config.addKey("ad.defaultUser", "");
+    config.addKey("ad.defaultPassword", "");
     config.addKey("ad.localized.Everyone", "Everyone");
     config.addKey("ad.localized.NTAuthority", "NT Authority");
     config.addKey("ad.localized.Interactive", "Interactive");
@@ -88,19 +88,19 @@
         }
       }
       String principal = singleServerConfig.get("user");
-      String passwd = singleServerConfig.get("password");
-      if (null == principal || principal.isEmpty()) {
+      if (null == principal) {
         principal = defaultUser;
-        if (null == passwd || passwd.isEmpty()) {
-          passwd = defaultPassword;
-        } else {
-          String err = "password without user for " + host;
-          throw new IllegalStateException(err);
-        }
       }
-      if (null == passwd || passwd.isEmpty()) {
-        String err = "no password for " + host;
-        throw new IllegalStateException(err);
+      if (principal.isEmpty()) {
+        throw new IllegalStateException("user not specified for host " + host);
+      }
+      String passwd = singleServerConfig.get("password");
+      if (null == passwd) {
+        passwd = defaultPassword;
+      }
+      if (passwd.isEmpty()) {
+        throw new IllegalStateException("password not specified for host "
+            + host);
       }
       AdServer adServer = new AdServer(method, host, port, principal, passwd);
       servers.add(adServer);