)]}'
{
  "commit": "28cf77fd7b4891a693db0216e5cd833927ece7d0",
  "tree": "016b21a4385a5a2e0112e4f788de33d9240f96f4",
  "parents": [
    "bcf43a2241809f26d85cc995c4fb973ac4a9a884"
  ],
  "author": {
    "name": "Brett Johnson",
    "email": "Brett.Michael.Johnson@gmail.com",
    "time": "Tue Jul 01 17:23:36 2014 -0700"
  },
  "committer": {
    "name": "Brett Johnson",
    "email": "Brett.Michael.Johnson@gmail.com",
    "time": "Wed Jul 02 15:08:13 2014 -0700"
  },
  "message": "Fix b/15667934: Removed files log \"The path ... is not a supported file type.\"\n\nFiles that were moved or deleted would log a message claiming the file\nis not a supported file type. This is because FsAdaptor.isSupportedPath()\nreturns false as the non-existent file is neither a directory, nor\na regular file.\n\nReading the BasicFileAttributes on a non-existent file throws an\nexception. So I catch the various not found exceptions, and\nmoved the call to isSupportedPath() to after the attributes are fetched.\n\nMoving the call to isSupportedPath() down also fixed a broken FsAdaptor\ntest, so I removed the comment that said the test was invalid.\n\nNext, the method name, isSupportedPath(), and the log message generated\nif it returns false were confusing to the user.  Some users thought\nthat \"unsupported file type\" was refering to the file contents, like\nJPEGs or AIFFs.  In reality, the method was checking that the path was\na regular file or a directory, not a link or a special file (like PRN).\nI changed the name of the method to isFileOrFolder() and the modified\nthe text of the log message to clarify.\n\nFinally, I tuned some of the log levels, choosing INFO or FINE, rather\nthan WARNING for normal, expected behaviours.\n\nCode Review: https://codereview.appspot.com/110330046/\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "977f924cd049137c56e0c3dd51e2e9d4d8f2d292",
      "old_mode": 33188,
      "old_path": "src/com/google/enterprise/adaptor/fs/FsAdaptor.java",
      "new_id": "faa36f5c7ba174cb621c3fae130b5fea5ae12d86",
      "new_mode": 33188,
      "new_path": "src/com/google/enterprise/adaptor/fs/FsAdaptor.java"
    },
    {
      "type": "modify",
      "old_id": "c756af831b233dda14acbcdd5ac99def27584ed8",
      "old_mode": 33188,
      "old_path": "test/com/google/enterprise/adaptor/fs/FsAdaptorTest.java",
      "new_id": "6a5b25f820cc908b369c75965effa7311a0228ee",
      "new_mode": 33188,
      "new_path": "test/com/google/enterprise/adaptor/fs/FsAdaptorTest.java"
    },
    {
      "type": "modify",
      "old_id": "761fdd9d47aebfd2df359daeb9cb2c22bc89df49",
      "old_mode": 33188,
      "old_path": "test/com/google/enterprise/adaptor/fs/NioFileDelegateTest.java",
      "new_id": "ee79e96f2a90fd08a79442145e8ce4ee33001598",
      "new_mode": 33188,
      "new_path": "test/com/google/enterprise/adaptor/fs/NioFileDelegateTest.java"
    }
  ]
}