commit 37fabb4dbd62218a92b62c2a380857e8bdfd236f
author Dirk Reinbach <dirk.reinbach@gmail.com> Thu Jan 14 10:01:18 2021 +0100
committer Paul Wankadia <junyer@google.com> Fri Jan 15 10:41:52 2021 +0000
tree 56ffd65553e71216459a74688426e56a0343bd35
parent c33d1680c7e9ab7edea02d7465a8db13e80b558d

use target_include_directories() instead of include_directories().

Fixes #292.

Change-Id: If1cf4ad7836acd8d824a8b1e8de364a222a01e21
Reviewed-on: https://code-review.googlesource.com/c/re2/+/58150
Reviewed-by: Paul Wankadia <junyer@google.com>

CMakeLists.txt

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 44a4772..ed5ef13 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -56,8 +56,6 @@
   list(APPEND EXTRA_TARGET_LINK_LIBRARIES pcre)
 endif()
 
-include_directories(${CMAKE_CURRENT_SOURCE_DIR})
-
 set(RE2_SOURCES
     re2/bitstate.cc
     re2/compile.cc
@@ -84,6 +82,7 @@
     )
 
 add_library(re2 ${RE2_SOURCES})
+target_include_directories (re2 PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>)
 add_library(re2::re2 ALIAS re2)
 
 if(RE2_BUILD_TESTING)
@@ -99,6 +98,7 @@
       )
 
   add_library(testing STATIC ${TESTING_SOURCES})
+  target_link_libraries(testing PUBLIC re2)
 
   set(TEST_TARGETS
       charclass_test
@@ -130,13 +130,13 @@
 
   foreach(target ${TEST_TARGETS})
     add_executable(${target} re2/testing/${target}.cc util/test.cc)
-    target_link_libraries(${target} testing re2 ${EXTRA_TARGET_LINK_LIBRARIES})
+    target_link_libraries(${target} testing ${EXTRA_TARGET_LINK_LIBRARIES})
     add_test(NAME ${target} COMMAND ${target})
   endforeach(target)
 
   foreach(target ${BENCHMARK_TARGETS})
     add_executable(${target} re2/testing/${target}.cc util/benchmark.cc)
-    target_link_libraries(${target} testing re2 ${EXTRA_TARGET_LINK_LIBRARIES})
+    target_link_libraries(${target} testing ${EXTRA_TARGET_LINK_LIBRARIES})
   endforeach(target)
 endif()