code /
re2 /
891529fb534f225d88f52eb9f6933c77bf397e4f Set `CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS` again.
GoogleTest on Windows made MSVC's linker give "already defined in
testing.lib(exhaustive_tester.obj)" errors. In hindsight, we were
forcing `testing` to be a static library, so exporting symbols or
not was irrelevant, which is probably why the change didn't help.
And now we don't force `testing` to be a static library, so we do
need to export symbols when it's a shared library.
Fixes #429.
Change-Id: I62ce1d1eeb125f5cb23c02ad21e2eb07d9780977
Reviewed-on: https://code-review.googlesource.com/c/re2/+/61391
Reviewed-by: Paul Wankadia <junyer@google.com>
Reviewed-by: Perry Lorier <perryl@google.com>
1 file changed