completion: drop "stash save" completion altogether
It's been deprecated since fd2ebf14db (stash: mark "git stash save"
deprecated in the man page, 2017-10-22) and the previous commit removed
further documentation suggesting to use it.
Since we recommend push instead, stop completing for "save" and remove a
special case in completion code. It still appears for "git stash <tab>"
when GIT_COMPLETION_SHOW_ALL=1, and when typed explicitly we still
complete options for
git stash save --<tab>
which is helpful for folks with finger-memory for save.
Signed-off-by: D. Ben Knoble <ben.knoble@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 697fef5..9cd9c7c 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -3558,16 +3558,13 @@
__git_resolve_builtins stash
subcommands="$___git_resolved_builtins"
- subcommand="$(__git_find_on_cmdline "$subcommands save")"
+ subcommand="$(__git_find_on_cmdline "$subcommands")"
if [ -z "$subcommand" ]; then
case "$((cword - __git_cmd_idx)),$cur" in
*,--*)
__gitcomp_builtin stash_push
;;
- 1,sa*)
- __gitcomp "save"
- ;;
1,*)
__gitcomp "$subcommands"
;;