sort_string_list(): rename to string_list_sort() The new name is more consistent with the names of other string_list-related functions. Suggested-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/Documentation/technical/api-string-list.txt b/Documentation/technical/api-string-list.txt index d51a657..c08402b 100644 --- a/Documentation/technical/api-string-list.txt +++ b/Documentation/technical/api-string-list.txt
@@ -29,7 +29,7 @@ `unsorted_string_list_has_string` and get it from the list using `string_list_lookup` for sorted lists. -. Can sort an unsorted list using `sort_string_list`. +. Can sort an unsorted list using `string_list_sort`. . Can remove duplicate items from a sorted list using `string_list_remove_duplicates`. @@ -146,7 +146,7 @@ ownership of a malloc()ed string to a `string_list` that has `strdup_string` set. -`sort_string_list`:: +`string_list_sort`:: Sort the list's entries by string value in `strcmp()` order.
diff --git a/builtin/apply.c b/builtin/apply.c index 6696ea4..22218f9 100644 --- a/builtin/apply.c +++ b/builtin/apply.c
@@ -4180,7 +4180,7 @@ if (cpath.nr) { struct string_list_item *item; - sort_string_list(&cpath); + string_list_sort(&cpath); for_each_string_list_item(item, &cpath) fprintf(stderr, "U %s\n", item->string); string_list_clear(&cpath, 0);
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c index 32fc540..d7ce643 100644 --- a/builtin/receive-pack.c +++ b/builtin/receive-pack.c
@@ -964,7 +964,7 @@ string_list_append(&ref_list, cmd->ref_name); item->util = (void *)cmd; } - sort_string_list(&ref_list); + string_list_sort(&ref_list); for (cmd = commands; cmd; cmd = cmd->next) { if (!cmd->error_string)
diff --git a/builtin/remote.c b/builtin/remote.c index 7fec170..46ecfd9 100644 --- a/builtin/remote.c +++ b/builtin/remote.c
@@ -352,9 +352,9 @@ free_refs(stale_refs); free_refs(fetch_map); - sort_string_list(&states->new); - sort_string_list(&states->tracked); - sort_string_list(&states->stale); + string_list_sort(&states->new); + string_list_sort(&states->tracked); + string_list_sort(&states->stale); return 0; } @@ -909,7 +909,7 @@ get_push_ref_states(remote_refs, states); } else { for_each_ref(append_ref_to_tracked_list, states); - sort_string_list(&states->tracked); + string_list_sort(&states->tracked); get_push_ref_states_noquery(states); } @@ -1128,7 +1128,7 @@ if (!result) { int i; - sort_string_list(&list); + string_list_sort(&list); for (i = 0; i < list.nr; i++) { struct string_list_item *item = list.items + i; if (verbose) @@ -1333,7 +1333,7 @@ for_each_string_list_item(item, &states.stale) string_list_append(&refs_to_prune, item->util); - sort_string_list(&refs_to_prune); + string_list_sort(&refs_to_prune); if (!dry_run) { struct strbuf err = STRBUF_INIT;
diff --git a/builtin/repack.c b/builtin/repack.c index 2845620..0705d68 100644 --- a/builtin/repack.c +++ b/builtin/repack.c
@@ -379,7 +379,7 @@ if (delete_redundant) { int opts = 0; - sort_string_list(&names); + string_list_sort(&names); for_each_string_list_item(item, &existing_packs) { char *sha1; size_t len = strlen(item->string);
diff --git a/connect.c b/connect.c index d47d0ec..16f74b0 100644 --- a/connect.c +++ b/connect.c
@@ -93,7 +93,7 @@ parse_one_symref_info(&symref, val, len); feature_list = val + 1; } - sort_string_list(&symref); + string_list_sort(&symref); for (; ref; ref = ref->next) { struct string_list_item *item;
diff --git a/notes.c b/notes.c index 5fe691d..40f4418 100644 --- a/notes.c +++ b/notes.c
@@ -902,7 +902,7 @@ if (string_list_add_note_lines(&sort_uniq_list, new_sha1)) goto out; string_list_remove_empty_items(&sort_uniq_list, 0); - sort_string_list(&sort_uniq_list); + string_list_sort(&sort_uniq_list); string_list_remove_duplicates(&sort_uniq_list, 0); /* create a new blob object from sort_uniq_list */
diff --git a/remote.c b/remote.c index f624217..ae4ecfa 100644 --- a/remote.c +++ b/remote.c
@@ -1356,7 +1356,7 @@ } clear_commit_marks_many(sent_tips.nr, sent_tips.tip, TMP_MARK); - sort_string_list(&dst_tag); + string_list_sort(&dst_tag); /* Collect tags they do not have. */ for (ref = src; ref; ref = ref->next) { @@ -1421,7 +1421,7 @@ for ( ; ref; ref = ref->next) string_list_append_nodup(ref_index, ref->name)->util = ref; - sort_string_list(ref_index); + string_list_sort(ref_index); } /* @@ -2135,7 +2135,7 @@ info.ref_count = ref_count; for (ref = fetch_map; ref; ref = ref->next) string_list_append(&ref_names, ref->name); - sort_string_list(&ref_names); + string_list_sort(&ref_names); for_each_ref(get_stale_heads_cb, &info); string_list_clear(&ref_names, 0); return stale_refs;
diff --git a/sha1_file.c b/sha1_file.c index d7f1838..30995e6 100644 --- a/sha1_file.c +++ b/sha1_file.c
@@ -1198,7 +1198,7 @@ if (!report_garbage) return; - sort_string_list(list); + string_list_sort(list); for (i = 0; i < list->nr; i++) { const char *path = list->items[i].string;
diff --git a/string-list.c b/string-list.c index c5aa076..2f69c32 100644 --- a/string-list.c +++ b/string-list.c
@@ -220,7 +220,7 @@ /* Yuck */ static compare_strings_fn compare_for_qsort; -/* Only call this from inside sort_string_list! */ +/* Only call this from inside string_list_sort! */ static int cmp_items(const void *a, const void *b) { const struct string_list_item *one = a; @@ -228,7 +228,7 @@ return compare_for_qsort(one->string, two->string); } -void sort_string_list(struct string_list *list) +void string_list_sort(struct string_list *list) { compare_for_qsort = list->cmp ? list->cmp : strcmp; qsort(list->items, list->nr, sizeof(*list->items), cmp_items);
diff --git a/string-list.h b/string-list.h index 494eb5d..2cc5e48 100644 --- a/string-list.h +++ b/string-list.h
@@ -85,7 +85,7 @@ */ struct string_list_item *string_list_append_nodup(struct string_list *list, char *string); -void sort_string_list(struct string_list *list); +void string_list_sort(struct string_list *list); int unsorted_string_list_has_string(struct string_list *list, const char *string); struct string_list_item *unsorted_string_list_lookup(struct string_list *list, const char *string);