| commit | 0549e5385ec8edecb790bf35d4fbb5f72e83fc53 | [log] [tgz] |
|---|---|---|
| author | Emmanuel T Odeke <emmanuel@orijtech.com> | Fri Aug 16 19:30:05 2019 -0600 |
| committer | Emmanuel Odeke <emm.odeke@gmail.com> | Sat Aug 17 07:10:52 2019 +0000 |
| tree | dade634a45df77020a7b163a27405e150893f153 | |
| parent | 84cf8946facaf65a7d9445f600edc573881bf3a5 [diff] |
storage/internal/benchserver: make body reads idempotent
When we converted "files" to be
map[string]io.Reader
we used an io.LimitedReader that then unfortunately
meant that multiple runs wouldn't stream back the
content. That's because when io.LimitedReader hits
io.EOF, we need to reset its N for it to read
more from rand.Reader.
This would then mean that the second request would
stream back 0 bytes, which is not what we want.
An update to make this reset would be a bit complex,
so instead make "files"
map[string]int64
mapping the file name to its size. When a request
is then made for the file, we'll create a fresh
io.LimitedReader, which produces the correct behavior.
Change-Id: I609da9458fc28efece4967a73520b5ac6214f6cb
Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/44191
Reviewed-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alex Hong <hongalex@google.com>
Go packages for Google Cloud Platform services.
import "cloud.google.com/go"
To install the packages on your system, do not clone the repo. Instead use
$ go get -u cloud.google.com/go/...
NOTE: Some of these packages are under development, and may occasionally make backwards-incompatible changes.
NOTE: Github repo is a mirror of https://code.googlesource.com/gocloud.
Alpha status: the API is still being actively developed. As a result, it might change in backward-incompatible ways and is not recommended for production use.
Beta status: the API is largely complete, but still has outstanding features and bugs to be addressed. There may be minor backwards-incompatible changes where necessary.
Stable status: the API is mature and ready for production use. We will continue addressing bugs and feature requests.
Documentation and examples are available at godoc.org/cloud.google.com/go
We support the two most recent major versions of Go. If Google App Engine uses an older version, we support that as well.
By default, each API will use Google Application Default Credentials for authorization credentials used in calling the API endpoints. This will allow your application to run in many environments without requiring explicit configuration.
client, err := storage.NewClient(ctx)
To authorize using a JSON key file, pass option.WithCredentialsFile to the NewClient function of the desired package. For example:
client, err := storage.NewClient(ctx, option.WithCredentialsFile("path/to/keyfile.json"))
You can exert more control over authorization by using the golang.org/x/oauth2 package to create an oauth2.TokenSource. Then pass option.WithTokenSource to the NewClient function: snip:# (auth-ts)
tokenSource := ...
client, err := storage.NewClient(ctx, option.WithTokenSource(tokenSource))
Contributions are welcome. Please, see the CONTRIBUTING document for details. We‘re using Gerrit for our code reviews. Please don’t open pull requests against this repo, new pull requests will be automatically closed.
Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms. See Contributor Code of Conduct for more information.