commit | dfaac1c2f56b9351bde36f07b10396eb72bf515d | [log] [tgz] |
---|---|---|
author | Emmanuel T Odeke <emmanuel@orijtech.com> | Wed Aug 14 11:02:01 2019 -0600 |
committer | Emmanuel Odeke <emm.odeke@gmail.com> | Tue Sep 03 17:56:40 2019 +0000 |
tree | b23114b240a54acd7dce4374239378da1a8b31c1 | |
parent | 5bc02cbce48731bbb1617d830561bb61da810c1e [diff] |
storage: remove duplicated retry logic Removes the duplicated retry logic that operated on the premise that since the logic from googleapis/gensupport.Resumable didn't retry the initial HTTP request that created a resumable upload session, so we'd retry it. However, for other HTTP requests such as when uploading chunks, gensupport.Resumable actually retried them, so really we ended up retrying twice the entirety of exponential backoff. On the event of a 429 or 5XX error, the logic from googleapis/gensupport.Resumable would run its course of retries e.g. [0, 2**n] and then fallback to the storage package's fallback which would then re-invoke a retry and also run the course of retries of a magnitude: [0, 2**m] which basically meant that we'd retry altogether: (2**n) * (2**m) = (2**(n+m)) times. This could easily become a very large number say if n=10, m=10 and say the base unit was a second: (2**20)seconds = ~12.13 days This change adds a regression test too to ensure that we don't regress from indefinite retries. There is still a lurking inconsistency from googleapis/gensupport in https://github.com/googleapis/google-api-go-client/issues/392, but for now it is better having the initial request not being retried than with indefinite retries but also when that issue fixed, all we'll need to do is have a single version update in our go.mod file. Fixes #1507 Follow-up https://github.com/googleapis/google-api-go-client/issues/392 Change-Id: I676c06d07194ba0522194bba72a6386ecbc62391 Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/44071 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jean de Klerk <deklerk@google.com>
Go packages for Google Cloud Platform services.
import "cloud.google.com/go"
To install the packages on your system, do not clone the repo. Instead use
$ go get -u cloud.google.com/go/...
NOTE: Some of these packages are under development, and may occasionally make backwards-incompatible changes.
NOTE: Github repo is a mirror of https://code.googlesource.com/gocloud.
Alpha status: the API is still being actively developed. As a result, it might change in backward-incompatible ways and is not recommended for production use.
Beta status: the API is largely complete, but still has outstanding features and bugs to be addressed. There may be minor backwards-incompatible changes where necessary.
Stable status: the API is mature and ready for production use. We will continue addressing bugs and feature requests.
Documentation and examples are available at godoc.org/cloud.google.com/go
We support the two most recent major versions of Go. If Google App Engine uses an older version, we support that as well.
By default, each API will use Google Application Default Credentials for authorization credentials used in calling the API endpoints. This will allow your application to run in many environments without requiring explicit configuration.
client, err := storage.NewClient(ctx)
To authorize using a JSON key file, pass option.WithCredentialsFile
to the NewClient
function of the desired package. For example:
client, err := storage.NewClient(ctx, option.WithCredentialsFile("path/to/keyfile.json"))
You can exert more control over authorization by using the golang.org/x/oauth2
package to create an oauth2.TokenSource
. Then pass option.WithTokenSource
to the NewClient
function: snip:# (auth-ts)
tokenSource := ...
client, err := storage.NewClient(ctx, option.WithTokenSource(tokenSource))
Contributions are welcome. Please, see the CONTRIBUTING document for details. We‘re using Gerrit for our code reviews. Please don’t open pull requests against this repo, new pull requests will be automatically closed.
Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms. See Contributor Code of Conduct for more information.