commit | 80979225afc76a1e08783859dc578ff0c0cffabd | [log] [tgz] |
---|---|---|
author | Olav Loite <koloite@gmail.com> | Sun Apr 21 10:52:16 2019 +0200 |
committer | Knut Olav Løite <koloite@gmail.com> | Mon Oct 28 08:14:56 2019 +0000 |
tree | eaaa1ab7ddb6db6ef010847cc454cde58cdb8cb8 | |
parent | 192e002f6cb79ae84a207270db9539a30f2d8cea [diff] |
spanner: keep better track of max sessions The session pool did not keep proper track of the max number of sessions in use within one maintenance window. This change ensures that the max number of sessions in use is actually kept track of per window, and prevents the maintainer from deleting sessions too eagerly. This will change the behavior of the session pool and lead to the pool keeping more sessions in the pool for a longer time, and to less deletion and creation of sessions. The logic is now: 1. Keep track of the max number of sessions in use when a session is taken from the pool, instead of probing this only at the moment that the maintainer is running. This prevents the session pool from missing spikes in session usage. 2. Store the max number of sessions during a health check cycle in a maintenance window struct containing one value for each cycle in an entire window of 10 cycles. 3. Only delete sessions after at least one full maintenance window has passed. After that, the maintainer will delete sessions based on a rolling set of maxSessionsInUse for the last 10 minutes. 4. The shrinkPool and replenishPool both take a max number of sessions to delete/create as an argument in order to prevent the methods from deleting/creating more sessions than intended if the number of sessions in the pool change as a result of other operations on the pool. 5. If the shrinkPool method notices that the session pool has started creating new sessions, the method will stop deleting any further sessions. Fixes #1303, #1382, #1398 and #1406. Change-Id: I20c0821a45b8ce02cb09a9dc492d389da03cccab Reviewed-on: https://code-review.googlesource.com/c/gocloud/+/40150 Reviewed-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Shanika Kuruppu <skuruppu@google.com> Reviewed-by: Jean de Klerk <deklerk@google.com>
Go packages for Google Cloud Platform services.
import "cloud.google.com/go"
To install the packages on your system, do not clone the repo. Instead:
Change to your project directory:
cd /my/cloud/project
Get the package you want to use. Some products have their own module, so it's best to go get
the package(s) you want to use:
$ go get cloud.google.com/go/firestore # Replace with the package you want to use.
NOTE: Some of these packages are under development, and may occasionally make backwards-incompatible changes.
NOTE: Github repo is a mirror of https://code.googlesource.com/gocloud.
Alpha status: the API is still being actively developed. As a result, it might change in backward-incompatible ways and is not recommended for production use.
Beta status: the API is largely complete, but still has outstanding features and bugs to be addressed. There may be minor backwards-incompatible changes where necessary.
Stable status: the API is mature and ready for production use. We will continue addressing bugs and feature requests.
Documentation and examples are available at godoc.org/cloud.google.com/go
We support the two most recent major versions of Go. If Google App Engine uses an older version, we support that as well.
By default, each API will use Google Application Default Credentials for authorization credentials used in calling the API endpoints. This will allow your application to run in many environments without requiring explicit configuration.
client, err := storage.NewClient(ctx)
To authorize using a JSON key file, pass option.WithCredentialsFile
to the NewClient
function of the desired package. For example:
client, err := storage.NewClient(ctx, option.WithCredentialsFile("path/to/keyfile.json"))
You can exert more control over authorization by using the golang.org/x/oauth2
package to create an oauth2.TokenSource
. Then pass option.WithTokenSource
to the NewClient
function: snip:# (auth-ts)
tokenSource := ...
client, err := storage.NewClient(ctx, option.WithTokenSource(tokenSource))
Contributions are welcome. Please, see the CONTRIBUTING document for details. We‘re using Gerrit for our code reviews. Please don’t open pull requests against this repo, new pull requests will be automatically closed.
Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms. See Contributor Code of Conduct for more information.