commit 1c72603e6b6ab7c0f889dcc0701072d1ef5f25b3
author Marc Kriguer <myk@google.com> Tue Nov 19 14:46:59 2013 -0800
committer Marc Kriguer <myk@google.com> Tue Nov 19 15:13:24 2013 -0800
tree e3415bc124735bf203f1a5eab17634c2ccff45d5
parent d15182722edc862ec55182340d0e309416ba1cf4

Require authorized user to download diagnostics.zip

Tested manually: before the code change, visiting the zip file URL
successfully generated and downloaded the diagnostics .zip file; after
the fix, the GET now returns " [403  Forbidden] " from an anonymous
window, but generates the .zip file when the admin is logged in.

src/com/google/enterprise/adaptor/Dashboard.java

diff --git a/src/com/google/enterprise/adaptor/Dashboard.java b/src/com/google/enterprise/adaptor/Dashboard.java
index 3e47311..80163dc 100644
--- a/src/com/google/enterprise/adaptor/Dashboard.java
+++ b/src/com/google/enterprise/adaptor/Dashboard.java
@@ -87,7 +87,9 @@
     addFilters(scope.createContext("/rpc", createAdminSecurityHandler(
         rpcHandler, config, sessionManager, secure)));
     addFilters(scope.createContext("/diagnostics-support.zip",
-        new DownloadDumpHandler(config.getFeedName().replace('_', '-'))));
+        createAdminSecurityHandler(new DownloadDumpHandler(
+            config.getFeedName().replace('_', '-')),
+            config, sessionManager, secure)));
     addFilters(scope.createContext("/",
           new RedirectHandler(contextPrefix + "/dashboard")));
   }